Skip to content

Commit

Permalink
Add a couple of TODOs.
Browse files Browse the repository at this point in the history
  • Loading branch information
alexrp committed May 2, 2023
1 parent 95df8b5 commit 29063c1
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/language/tooling/Projects/ProjectConfiguration.cs
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,8 @@ static void Error(string message)

if (Path.IsPathFullyQualified(path))
Error("'path' property, if present, must be relative.");

// TODO: It would be good to verify that the path does not contain any . or .. segments.
}

var paths = ImmutableDictionary<ModulePath, string>.Empty;
Expand Down Expand Up @@ -121,6 +123,8 @@ static void Error(string message)
if (Path.IsPathFullyQualified(dir))
Error($"Directory path for module path '{prop.Name}' must be relative.");

// TODO: It would be good to verify that the path does not contain any . or .. segments.

paths = paths.SetItem(modPath, dir);
}
}
Expand Down

0 comments on commit 29063c1

Please sign in to comment.