Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support docker volume type and size #370

Merged
merged 13 commits into from
Jun 11, 2024
Merged

Conversation

okozachenko1203
Copy link
Member

@okozachenko1203 okozachenko1203 commented May 3, 2024

fix #4

@okozachenko1203 okozachenko1203 marked this pull request as draft May 3, 2024 14:47
@okozachenko1203
Copy link
Member Author

okozachenko1203 commented May 3, 2024

@mnaser i think we need to solve the followings still;

@okozachenko1203 okozachenko1203 marked this pull request as ready for review May 14, 2024 08:37
@okozachenko1203
Copy link
Member Author

recheck

Copy link
Member

@mnaser mnaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why we have multiple cases here instead of simply using json patches that layer up onto each other.

@mnaser mnaser merged commit 5360349 into main Jun 11, 2024
11 of 12 checks passed
@mnaser mnaser deleted the support-docker-volume branch June 11, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for docker_volume_{size,type}
2 participants