feat: Support OpenID Connect for kube-api auth #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnaser
requested changes
Jun 26, 2023
There was a problem hiding this comment.
This works great, but I have some ideas around cleaning up the UI:
Since oidc_issuer_url is an absolute requirement, no matter what, it will always be set if you're using OpenID connect, we can probably use that as a label to decide if it's on or not (and not rely on oidc_enabled instead).
mnaser
requested changes
Jun 26, 2023
okozachenko1203
force-pushed
the
add-oidc-labels
branch
from
5a33e48
to
a04f956
Compare
okozachenko1203
force-pushed
the
add-oidc-labels
branch
from
f50e8ec
to
e78fb8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #119