Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VTR format checking / auto-format not checked by CI? #2677

Open
vaughnbetz opened this issue Aug 6, 2024 · 0 comments
Open

VTR format checking / auto-format not checked by CI? #2677

vaughnbetz opened this issue Aug 6, 2024 · 0 comments
Assignees

Comments

@vaughnbetz
Copy link
Contributor

Various PRs have shown formatting changes to break long multi-lines. I think make format should do this automatically; this issue is to see if we have a missing rule in autoformat, or even worse, if auto-format is breaking manually made format changes for readability.

We should also have CI checking that our formatting is consistent.
Assigning to @soheilshahrouz since he has been cleaning up some code formatting; I think it would be better to figure out if there is a shortcoming in make format. I think @jgoeders knows the autoformatting, so he could potentially help if you're stuck on how to improve it.

Expected Behaviour

make format should format long subroutine calls or subroutine variable declarations properly. CI should test that we are format compliant.

Current Behaviour

I'm not 100% sure, but it seems long lines aren't caught by CI, and perhaps are not fixed by make format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants