You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Various PRs have shown formatting changes to break long multi-lines. I think make format should do this automatically; this issue is to see if we have a missing rule in autoformat, or even worse, if auto-format is breaking manually made format changes for readability.
We should also have CI checking that our formatting is consistent.
Assigning to @soheilshahrouz since he has been cleaning up some code formatting; I think it would be better to figure out if there is a shortcoming in make format. I think @jgoeders knows the autoformatting, so he could potentially help if you're stuck on how to improve it.
Expected Behaviour
make format should format long subroutine calls or subroutine variable declarations properly. CI should test that we are format compliant.
Current Behaviour
I'm not 100% sure, but it seems long lines aren't caught by CI, and perhaps are not fixed by make format.
The text was updated successfully, but these errors were encountered:
Various PRs have shown formatting changes to break long multi-lines. I think make format should do this automatically; this issue is to see if we have a missing rule in autoformat, or even worse, if auto-format is breaking manually made format changes for readability.
We should also have CI checking that our formatting is consistent.
Assigning to @soheilshahrouz since he has been cleaning up some code formatting; I think it would be better to figure out if there is a shortcoming in make format. I think @jgoeders knows the autoformatting, so he could potentially help if you're stuck on how to improve it.
Expected Behaviour
make format should format long subroutine calls or subroutine variable declarations properly. CI should test that we are format compliant.
Current Behaviour
I'm not 100% sure, but it seems long lines aren't caught by CI, and perhaps are not fixed by make format.
The text was updated successfully, but these errors were encountered: