Skip to content

Commit

Permalink
chore: update deps (#1345)
Browse files Browse the repository at this point in the history
* chore: update deps

* switch to npm

* fix install

* new lockfile

* coverage

* fix coverage
  • Loading branch information
domoritz authored Aug 31, 2024
1 parent e88dff0 commit 3080b82
Show file tree
Hide file tree
Showing 9 changed files with 15,127 additions and 7,312 deletions.
11 changes: 6 additions & 5 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,17 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v4
with:
cache: "yarn"
cache: "npm"
node-version: 20

- name: Install Node dependencies
run: yarn --frozen-lockfile
run: npm ci

- run: yarn lint
- run: yarn build
- run: npm run lint
- run: npm run build

- name: Test coverage
run: yarn test --coverage
run: npm test -- --coverage

- name: Upload coverage to Codecov
uses: codecov/[email protected]
Expand Down
2 changes: 1 addition & 1 deletion .release-it.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"release": true
},
"hooks": {
"after:bump": "yarn build"
"after:bump": "npm run build"
},
"plugins": {
"@release-it/conventional-changelog": {
Expand Down
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -217,11 +217,11 @@ When using [container](https://vega.github.io/vega-lite/docs/size.html#specifyin

## Build Process

To build `vega-embed.js` and view the test examples, you must have [Yarn 1](https://classic.yarnpkg.com/) installed.
To build `vega-embed.js` and view the test examples, you must have npm installed.

1. Run `yarn` in the Vega-Embed folder to install dependencies.
2. Run `yarn build`. This will create `vega-embed.js` and the minified `vega-embed.min.js`.
3. Run a local webserver with `yarn start` then point your web browser at the test page (e.g., `http://localhost:8000/test-vg.html`(Vega) or `http://localhost:8000/test-vl.html`(Vega-Lite)).
1. Run `npm install` in the Vega-Embed folder to install dependencies.
2. Run `npm run build`. This will create `vega-embed.js` and the minified `vega-embed.min.js`.
3. Run a local webserver with `npm run start` then point your web browser at the test page (e.g., `http://localhost:8000/test-vg.html`(Vega) or `http://localhost:8000/test-vl.html`(Vega-Lite)).

## Publishing

Expand Down
2 changes: 1 addition & 1 deletion build-style.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/usr/bin/env bash

printf "// generated with build-style.sh\nexport default \`" > src/style.ts
yarn -s sass vega-embed.scss >> src/style.ts
npx sass vega-embed.scss >> src/style.ts
echo "\`;" >> src/style.ts
1 change: 0 additions & 1 deletion eslint.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ export default [
...vitest.configs.recommended.rules,
"prettier/prettier": "warn",
"@typescript-eslint/explicit-function-return-type": "off",
"@typescript-eslint/ban-types": "warn",
"@typescript-eslint/no-explicit-any": "warn",
"@typescript-eslint/prefer-for-of": "error",
"@typescript-eslint/no-for-in-array": "error",
Expand Down
Loading

0 comments on commit 3080b82

Please sign in to comment.