Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align CSS with VUI #71

Merged
merged 13 commits into from
Aug 17, 2023
Merged

Align CSS with VUI #71

merged 13 commits into from
Aug 17, 2023

Conversation

cjcenizal
Copy link
Collaborator

Screenshots

Light mode

image

image

image

image

Dark mode

image

image

image

image

@netlify
Copy link

netlify bot commented Aug 15, 2023

Deploy Preview for luxury-shortbread-acee05 ready!

Name Link
🔨 Latest commit de9cfc7
🔍 Latest deploy log https://app.netlify.com/sites/luxury-shortbread-acee05/deploys/64de2c2db6084800087825b8
😎 Deploy Preview https://deploy-preview-71--luxury-shortbread-acee05.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cjcenizal
Copy link
Collaborator Author

CC @eskibars @danielone Still a work in progress, just giving you a head's up. Feedback welcome!

@cjcenizal cjcenizal changed the title [WIP] Align CSS with VUI Align CSS with VUI Aug 16, 2023
@cjcenizal
Copy link
Collaborator Author

@eskibars @danielone @pwoznic This is ready for review!

@cjcenizal
Copy link
Collaborator Author

Note that the styles have evolved past the point at which the screenshots were taken. To see the latest changes please run this branch locally.

Copy link
Contributor

@pwoznic pwoznic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this redesign, specifically the fonts and the light/dark theme toggle! The dark theme really brings out the contrast of the code blocks. I also really like the TOC because there is less white space in between the headings so there is less scrolling.

@cjcenizal
Copy link
Collaborator Author

This change is cosmetic so I'm going to merge it. It will be trivial to revert this change if we need to.

@cjcenizal cjcenizal merged commit 19d1f4d into main Aug 17, 2023
5 of 6 checks passed
@cjcenizal cjcenizal deleted the feature/styles-facelift branch August 17, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants