Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output SWIM errors in hex, not decimal with hex prefix #167

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Output SWIM errors in hex, not decimal with hex prefix #167

wants to merge 1 commit into from

Conversation

rhulme
Copy link

@rhulme rhulme commented Sep 23, 2023

SWIM errors are currently printed with a hex prefix but the value is actually decimal:

ERROR2("SWIM error 0x%02d\n", status[set][0]);

This PR fixes that.

martin-kaiser
martin-kaiser approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@martin-kaiser martin-kaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.
Probably, most errors are <= 9. That's why people haven't spotted this yet...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-kaiser martin-kaiser martin-kaiser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhulme @martin-kaiser