feat: finalization helper for ValidationRuleResults #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Gillson <[email protected]>
dosubot
bot
added
size:M
ahmad-ibra
previously approved these changes
Sep 6, 2024
Signed-off-by: Tyler Gillson <[email protected]>
Signed-off-by: Tyler Gillson <[email protected]>
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #415 +/- ##
==========================================
+ Coverage 53.43% 54.30% +0.87%
==========================================
Files 22 22
Lines 1136 1138 +2
==========================================
+ Hits 607 618 +11
+ Misses 460 453 -7
+ Partials 69 67 -2
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
TylerGillson
added a commit
that referenced
this pull request
Sep 7, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.11](v0.1.10...v0.1.11) (2024-09-06) ### Features * finalization helper for ValidationRuleResults ([#415](#415)) ([ff7f786](ff7f786)) ### Dependency Updates * **deps:** update golang.org/x/exp digest to e7e105d ([#412](#412)) ([4ecf59f](4ecf59f)) * **deps:** update module sigs.k8s.io/cluster-api to v1.8.2 ([#414](#414)) ([288194c](288194c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
N/A
Description
Add finalization helper for ValidationRuleResults. It must be called in
Validatefor all plugins to ensure proper error handling in direct mode.