fix(fixer): restore the addition of the GitModified filter option #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure if it was correct to remove the filter. I need to test if its correct to use git modified here or remove and cleanup document range.
|
@valeryan I don't use VS Code regularly, what's the best way to test the functionality added back in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if it was correct to remove the filter. I need to test if its correct to use git modified here or remove and cleanup document range.
The logic for git modified was added here: #54
This logic was removed here: https://github.com/valeryan/vscode-phpsab/pull/55/files#diff-8252e32d33853b0c73ac8a3449d744d96025b7aa6926201d9ae16c4a6d3c079bL113
But did I remove it by mistake or for reason? The world may never know.