Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Germany holidays: add th localization, deprecated non-standard ISO code, add subdivision aliases #1979

Merged
merged 6 commits into from
Sep 10, 2024

Conversation

PPsyrius
Copy link
Collaborator

@PPsyrius PPsyrius commented Sep 5, 2024

Proposed change

This PR includes 3 changes for Germany 🇩🇪 holidays:

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7ab80ed) to head (7c4cd4a).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #1979   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          188       188           
  Lines        11403     11407    +4     
  Branches      1789      1790    +1     
=========================================
+ Hits         11403     11407    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

holidays/constants.py Outdated Show resolved Hide resolved
@PPsyrius
Copy link
Collaborator Author

PPsyrius commented Sep 6, 2024

Hmm, seems like we might be able to consolidate this a bit further:
image

KJhellico
KJhellico previously approved these changes Sep 6, 2024
Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

sonarcloud bot commented Sep 10, 2024

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇩🇪 LGTM

@arkid15r arkid15r added this pull request to the merge queue Sep 10, 2024
Merged via the queue into vacanza:dev with commit c225ae5 Sep 10, 2024
32 checks passed
@PPsyrius PPsyrius deleted the update_germany_holidays branch September 10, 2024 05:19
@arkid15r arkid15r mentioned this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants