Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jersey holidays #1971

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

PPsyrius
Copy link
Collaborator

@PPsyrius PPsyrius commented Sep 3, 2024

Proposed change

This PR adds Jul 15, 2024, as a public Holiday for Jersey as outlined in [1] [2].

Other Public holiday names are also changed to better match the actual usage in Jersey 🇯🇪 rather than the United Kingdom 🇬🇧 . i.e. %s (observed) is changed to %s (substitute day), Late Summer Public Holiday is simply called Summer Public Holiday, May Day is called Early May Bank Holiday (except in 2024 which is instead called May Bank Holiday)

Type of change

  • New country/market holidays support (thank you!)
  • Supported country/market holidays update (calendar discrepancy fix, localization)
  • Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
  • Dependency update (version deprecation/pin/upgrade)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (a code change causing existing functionality to break)
  • New feature (new python-holidays functionality in general)

Checklist

  • I've followed the contributing guidelines
  • I've run make pre-commit, it didn't generate any changes
  • I've run make test, all tests passed locally

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (44dd050) to head (42d9062).
Report is 5 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev     #1971   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          188       188           
  Lines        11403     11403           
  Branches      1789      1789           
=========================================
  Hits         11403     11403           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@KJhellico KJhellico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@KJhellico KJhellico changed the title Update Jersey Holidays Update Jersey holidays Sep 4, 2024
@arkid15r arkid15r added this pull request to the merge queue Sep 5, 2024
Merged via the queue into vacanza:dev with commit 063f25e Sep 5, 2024
31 checks passed
@PPsyrius PPsyrius deleted the jersey_jul15_holiday branch September 5, 2024 17:30
@arkid15r arkid15r mentioned this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants