Upgrade to Terraform 1.4.6 #1304
Conversation
| @@ -1,5 +1,5 @@ | |||
| terraform { | |||
| required_version = "1.0.10" | |||
| required_version = "1.4.6" | |||
There was a problem hiding this comment.
I'm all for this, but can we at least allow minor versions updates (~> 1.4.6) if not anything in the future by using >= 1.4.6.
There was a problem hiding this comment.
In the past we had it, to allow minor version updates. But terraform was so unstable even between minor versions that it could lead to introduction changes in sumaform code that were backward incompatible. For that reason, we start to fix the terraform version.
Can have updated the terraform version and it looked much more stable now.
From my side, I'm fine on allow minor version and see how it goes again.
There was a problem hiding this comment.
AFAICS, there haven't been any breaking changes since the first stable release, so I'm also fine trying this again. Plus, as long as we keep building terraform in OBS, we're still in charge of what actual version the testsuite uses.
There was a problem hiding this comment.
Well there was one, where we had to change cpu = { ... } to cpu { ... } in our sumaform files.
There was a problem hiding this comment.
but that was because of a libvirt plugin update, not a terraform update
cbbayburt
force-pushed
the
terraform-upgrade
branch
2 times, most recently
from
daaf7b6
to
dbdec77
Compare
cbbayburt
force-pushed
the
terraform-upgrade
branch
2 times, most recently
from
0f0a3ed
to
797ec88
Compare
|
You should probably update the PR when it is ready. We are already at version 1.5.2 😉 https://github.com/hashicorp/terraform/blob/v1.5/CHANGELOG.md |
|
Oh haha hard to catch up with them 😂 Last time I worked on this we had problems with Salt in the test suite so I had to leave it for the time. Now there are more pressing issues about sumaform so this is on hold for now. |
|
Yes, this is a never ending story. On my personal machine I use the version Tumbleweed ships which is currently also 1.5.2, and I have no issues so far. But our SUMA setup is quite different. If you need help with testing this PR in the future, just ping me. |
cbbayburt
force-pushed
the
terraform-upgrade
branch
from
797ec88
to
34ea8d1
Compare
cbbayburt
force-pushed
the
terraform-upgrade
branch
from
34ea8d1
to
424894b
Compare
|
If I am not wrong, the latest version with an open source license is 1.5.7. Maybe it should be our target for this PR. Then we could take our time to switch to openTofu 1.6.0 or upper. |
Upgrade to Terraform 1.4.6 (latest)
See OBS build
Fixes https://github.com/SUSE/spacewalk/issues/20256