This repository has been archived by the owner on Sep 27, 2021. It is now read-only.
OS Interface + Static Buffer Allocation #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lass without duplicating code, and prevent dynamic heap allocation
|
Runtime verified by @gokuldharan yesterday |
tygamvrelis
reviewed
Nov 7, 2018
| @@ -140,6 +141,7 @@ namespace{ | |||
|
|
|||
|
|
|||
| buffer::BufferMaster BufferMaster; | |||
| os::OsInterfaceImpl osInterfaceImpl; | |||
There was a problem hiding this comment.
It seems to me that we should only need one osInterfaceImpl in all of our code. However, the memory footprint of an object with only functions is fairly small so it should be ok (relevant repl: https://repl.it/repls/InfamousMatureApplescript)
tygamvrelis
suggested changes
Nov 7, 2018
Common/include/BufferBase.h
Outdated
| void set_lock(osMutexId lock) | ||
| { | ||
| m_lock = lock; | ||
| } | ||
| void write(const T &item) | ||
| { | ||
| xSemaphoreTake(m_lock, portMAX_DELAY); | ||
| *m_data_buf = item; | ||
| m_osInterfacePtr->OS_xSemaphoreTake(m_lock, portMAX_DELAY); |
There was a problem hiding this comment.
I think there's a cmsis version of portMAX_DELAY called osWaitForever or something like that. Could you try to use the cmsis one instead? Robert mentioned it recently and I think it's a good idea since cmsis is generic
tygamvrelis
approved these changes
Nov 10, 2018
…r doc changes Runtime verified + all tests passing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to allow direct testing of class without duplicating code, and prevent dynamic heap allocation