Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: docker api #45

Merged
merged 37 commits into from
Jul 1, 2024
Merged

fix: docker api #45

merged 37 commits into from
Jul 1, 2024

Conversation

loks0n
Copy link
Contributor

@loks0n loks0n commented Jun 12, 2024 •
edited
Loading

  • Improved DockerAPI class by adding headers to fix Swoole-related bugs and calculating CPU, disk, and memory stats
  • Added checks for Docker network operations to handle specific HTTP response codes for better error messaging
  • Added setUpBeforeClass method in tests/Orchestration/Base.php to clean up test containers and networks before running tests. This fixes running tests locally
  • Adjusted CPU usage assertions in testUsageStats to check for non-negative values

Includes some formatting changes from pint version bump

@loks0n loks0n mentioned this pull request Jun 12, 2024
Closed
loks0n
loks0n commented Jun 12, 2024
View reviewed changes
tests/Orchestration/Base.php Outdated Show resolved Hide resolved
byawitz
byawitz reviewed Jun 27, 2024
View reviewed changes
src/Orchestration/Adapter.php Show resolved Hide resolved
src/Orchestration/Adapter/DockerAPI.php Outdated Show resolved Hide resolved
src/Orchestration/Adapter/DockerAPI.php Show resolved Hide resolved
@loks0n loks0n requested review from Meldiron and byawitz and removed request for vermakhushboo July 1, 2024 09:57
@eldadfux eldadfux merged commit 458f47c into main Jul 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byawitz byawitz byawitz approved these changes

@Meldiron Meldiron Meldiron approved these changes

@christyjacob4 christyjacob4 christyjacob4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@loks0n @byawitz @Meldiron @christyjacob4 @eldadfux