Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test AVIF support 1 #21

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Test AVIF support 1 #21

wants to merge 18 commits into from

Conversation

eldadfux
Copy link
Member

@eldadfux eldadfux commented Aug 19, 2022 •
edited by stnguyen90
Loading

Added AVIF support which requires php8.1.

Related:

@eldadfux eldadfux marked this pull request as ready for review August 19, 2022 19:56
lohanidamodar
lohanidamodar requested changes Sep 4, 2022
View reviewed changes
Copy link
Contributor

@lohanidamodar lohanidamodar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. May be remove tests/.DS_Store file.

@eldadfux
Copy link
Member Author

eldadfux commented Sep 4, 2022

Fixed.

TorstenDittmann
TorstenDittmann requested changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@TorstenDittmann TorstenDittmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should adapt composer.json so it requires PHP 8.1

@eldadfux
Copy link
Member Author

We should adapt composer.json so it requires PHP 8.1

Fixed.

This was referenced Mar 3, 2024
Merged
Draft
@byawitz
Merge branch 'refs/heads/main' into feat-avif-support
c1de4f1 
# Conflicts:
#	.travis.yml
#	Dockerfile
#	docker-compose.yml
@byawitz
fix: Fixing images
7be404a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meldiron Meldiron Meldiron approved these changes

@christyjacob4 christyjacob4 christyjacob4 approved these changes

@TorstenDittmann TorstenDittmann Awaiting requested review from TorstenDittmann

@lohanidamodar lohanidamodar Awaiting requested review from lohanidamodar

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@eldadfux @TorstenDittmann @lohanidamodar @Meldiron @christyjacob4 @byawitz