Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/rename with same name for Environments #3199

Merged

Conversation

Pragadesh-45
Copy link
Contributor

fixes: #3198

Description

This PR fixes the issue where environments with only a case difference cannot be renamed (e.g., renaming ProD to Prod), which primarily affects macOS and Windows.

  • The fix involves using the safeToRename utility function to check if the files are identical based on their existence, rather than just comparing their names.
  • This approach is particularly useful for Unix/Linux systems, which support case-sensitive filesystems.
  • For more detailed context, see: Link

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Before:

20240926-0717-42.8500160.mp4

After:

20240926-0719-58.3692335.mp4

@helloanoop helloanoop merged commit 2e4051b into usebruno:main Sep 26, 2024
2 checks passed
@helloanoop
Copy link
Contributor

Merged! Thanks @Pragadesh-45 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to rename uppercase environment to lowercase environment
2 participants