Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved #1709 - Format json file content when download response #3185

Closed
wants to merge 9 commits into from

Conversation

sanjai0py
Copy link
Member

@sanjai0py sanjai0py commented Sep 24, 2024

Description

This PR improves the original PR #1709, addressing conflicts and updating the feature implementation.

  • Resolved merge conflicts
  • Code refactoring

Fixes #1708

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@helloanoop helloanoop closed this Sep 26, 2024
@sanjai0py sanjai0py deleted the pr-1709 branch September 26, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Format json code present at response downloaded file.
3 participants