-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide forecasted grants while UI is being developed to support forecasted grants #3456
base: main
Are you sure you want to change the base?
Conversation
QA Summary
Test CoverageCoverage report for `packages/client`
Coverage report for `packages/server`
|
Terraform Summary
Hint: If "Terraform Format & Style" failed, run OutputValidation Output
Plan Summary
Pusher: @masimons, Action: |
6a50a35
to
4ca864b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@masimons Confirming that the direction this is headed makes sense to me 👍
I'll mention that I think it could be useful to have an environment variable control the exclusion of forecasted grants. Due to how we ship and run Docker images, it's not something that we could toggle in a Staging/Prod environment without re-deploying, but 1) it might be helpful for development purposes, and 2) might make it easier to activate once we get to the point where we want to start including forecasted grants in one or both of those environments.
4ca864b
to
32a4bc3
Compare
@TylerHendrickson thanks for checking this out, I missed this comment. Out of curiosity, do you have an example off the top of your head where we use an env var in that way? I was looking into how we use feature flags, but it seems that those are scoped to the client side? |
@masimons re
The implementation details for #3060 provide some instructions for implementing an API-side feature flag using a Fundamentally, this sort of thing would entail the following:
I'd recommend that an environment variable that provides a binary feature flag be evaluated as a string using strict equality, e.g. |
15e2749
to
e0b63ab
Compare
Ticket #3213
Description
Hide forecasted grants on production during development and testing.
Screenshots / Demo Video
Testing
Automated and Unit Tests
Manual tests for Reviewer
Checklist