-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add client-side feature flag for Follow+Notes functionality #3440
Merged
sushilrajeeva
merged 5 commits into
main
from
sushilrajeeva/follow-notes-client-feature-flag
Sep 5, 2024
Merged
feat: Add client-side feature flag for Follow+Notes functionality #3440
sushilrajeeva
merged 5 commits into
main
from
sushilrajeeva/follow-notes-client-feature-flag
Sep 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced a new client-side feature flag named followNotesEnabled as part of the implementation for the "Follow + Note" feature - Implemented followNotesEnabled feature flag in index.js. - Registered the flag with default true in deploy-config.js. - Added flag to staging.tfvars and prod.tfvars with false default. - Reformatted lines 16-17 in deploy-config.js for ESLint compliance.
github-actions
bot
added
enhancement
New feature or request
Infra
Issues related to the infrastructure underlying all the tools.
javascript
Pull requests that update Javascript code
terraform
Pull requests that update Terraform code
labels
Aug 24, 2024
QA Summary
Test CoverageCoverage report for `packages/client`
Coverage report for `packages/server`
|
Terraform Summary
Hint: If "Terraform Format & Style" failed, run OutputValidation Output
Plan Summary
Pusher: @sushilrajeeva, Action: |
greg-adams
approved these changes
Sep 3, 2024
Comment on lines
+16
to
+20
// Reformatted according to common ESLint rules | ||
/* eslint-disable no-console */ | ||
// console.log('New feature flag overrides in page session:', window.sessionStorage.getItem(storageKey)); | ||
console.log(`New feature flag overrides in page session: ${window.sessionStorage.getItem(storageKey)}`); | ||
/* eslint-enable no-console */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
// Reformatted according to common ESLint rules | |
/* eslint-disable no-console */ | |
// console.log('New feature flag overrides in page session:', window.sessionStorage.getItem(storageKey)); | |
console.log(`New feature flag overrides in page session: ${window.sessionStorage.getItem(storageKey)}`); | |
/* eslint-enable no-console */ | |
/* eslint-disable no-console */ | |
console.log(`New feature flag overrides in page session: ${window.sessionStorage.getItem(storageKey)}`); |
7 tasks
sushilrajeeva
deleted the
sushilrajeeva/follow-notes-client-feature-flag
branch
September 5, 2024 20:24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
Infra
Issues related to the infrastructure underlying all the tools.
javascript
Pull requests that update Javascript code
terraform
Pull requests that update Terraform code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket #3405
Fixes #3405
Description
This PR introduces the followNotesEnabled feature flag in the client-side library, enabling conditional display of new Follow+Notes features. The flag is registered as true by default in development and false in staging and production environments. Lines 16-17 in deploy-config.js have been reformatted for ESLint compliance.
Screenshots / Demo Video
Testing
Automated and Unit Tests
Manual tests for Reviewer
Checklist