Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow+Notes: Create client-side feature flag #3405

Closed
Tracked by #2960
TylerHendrickson opened this issue Aug 16, 2024 · 1 comment · Fixed by #3440
Closed
Tracked by #2960

Follow+Notes: Create client-side feature flag #3405

TylerHendrickson opened this issue Aug 16, 2024 · 1 comment · Fixed by #3440
Assignees
Labels
collaboration good first issue Good for newcomers Grant Finder Issues related to the Grant Finder javascript Pull requests that update Javascript code terraform Pull requests that update Terraform code

Comments

@TylerHendrickson
Copy link
Member

TylerHendrickson commented Aug 16, 2024

Subtask of [STORY]: Update 'Status' to 'Follow + Note' feature #2960

Blocked by

N/A

Blocks

Definition of Done

A new feature flag, followNotesEnabled, is defined in the client-side library of feature flags.

Implementation details

(See also: our Feature Flags development guide.)

  • In packages/client/src/helpers/featureFlags/index.js, create a new function called followNotesEnabled() that returns a boolean value based on whether a feature flag named followNotesEnabled strictly evaluates (===) to true.
  • In packages/client/public/deploy-config.js, register the new followNotesEnabled with a value of true so that this feature is enabled by default in development environments.
    • Note: Lines 16-17 of this file are currently not formatted according to our ESLint rules. Please reformat so that this file is compliant.
  • In terraform/staging.tfvars, register the new followNotesEnabled feature flag within the website_feature_flags map with a value of false so that this feature is disable by default in our Staging environment.
  • In terraform/prod.tfvars, register the new followNotesEnabled feature flag within the website_feature_flags map with a value of false so that this feature is disable by default in our Production environment.
@ClaireValdivia
Copy link
Contributor

tried out the feature flag in staging and it is working as expected -thanks @sushilrajeeva !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
collaboration good first issue Good for newcomers Grant Finder Issues related to the Grant Finder javascript Pull requests that update Javascript code terraform Pull requests that update Terraform code
Projects
Status: 🚢 Completed
Development

Successfully merging a pull request may close this issue.

3 participants