Shutdown: Prep ECR for deletion #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs to recreated the lifecycle policies (which did get successfully deleted), but correctly knows this means no changes to the repositories themselves. I've added another commit to use force_delete, which I think will prep the repositories to delete correctly in the next PR. |
|
Part of #1550. |
Mr0grog
added a commit
that referenced
this pull request
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1581 did not succeed because the ECR repositories are not empty. I think we need. to set
force_deleteon them, then delete them. But first we'll see if restoring the configuration is going to cause Terraform to try and recreate them, or if it just puts things back into a good state.If it causes Terraform to try and recreate them, I'll close this and just delete them manually.