USAGOV-1773-clear-menu-link: #1923
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omerida
force-pushed
the
USAGOV-1773-clear-menu-link
branch
from
906a3d5
to
5f436d7
Compare
…ink cache. Needed when running a Tome export to build page navigation correctly when more than one path is exported by a process.
omerida
force-pushed
the
USAGOV-1773-clear-menu-link
branch
from
5f436d7
to
5fa0b27
Compare
akf
requested changes
Sep 13, 2024
scripts/tome-static.sh
Outdated
| @@ -30,7 +30,7 @@ echo "Starting Static Site Generation : "$(date) | |||
| mkdir -p /var/www/html | |||
| # time drush -vvv tome:static --uri=$URI --process-count=1 --path-count=1 | |||
| # time drush tome:static -y --uri=$URI --process-count=5 --path-count=1 | |||
| time drush tome:static -y --uri=$URI --process-count=$TOME_PROCESS_COUNT --path-count=1 | |||
| time drush tome:static -y --uri=$URI --process-count=$TOME_PROCESS_COUNT --path-count=10 | |||
There was a problem hiding this comment.
Let's drop this back down to 1.
I've identified what I think is another Tome bug; many details are on the Jira ticket.
| class RequestPrepareSubscriber implements EventSubscriberInterface { | ||
|
|
||
| public function __construct( | ||
| private MenuActiveTrailInterface $menu_active_trail, |
There was a problem hiding this comment.
Is this what you want to inherit from?
…out why higher path count saves redirects as the original page instead of a meta refresh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Task
https://cm-jira.usa.gov/browse/USAGOV-1937
Description
Adds an event subscriber to clear menu link cache.
Needed when running a Tome export to build page navigation correctly when more than one path is exported by a process.
Type of Changes
Testing Instructions
Change Requirements
Validation Steps
html/Security Review
Reviewer Reminders
Post PR Approval Instructions
Follow these steps as soon as you merge the new changes.
Review in Testand add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.