Usagov 358 bin script updates, trying again with simpler include call

[jacobaaronyeager]

Jira Task

https://cm-jira.usa.gov/browse/USAGOV-358

Description

Type of Changes

• New Feature
• Bugfix
• Frontend (Twig, Sass, JS)
  • Add screenshot showing what it should look like
• Drupal Config (requires "drush cim")
• New Modules (requires rebuild)
• Infrastructure
  • CMS
  • WAF
  • Egress
  • Tools
• Other

Testing Instructions

Requires New Config

• Yes
• No

Requires New Content

• Yes
• No

Validation Steps

• Test instruction 1
• Test instruction 2
• Test instruction 3

Security Review

• Adds/updates software (including a library or Drupal module)
• Communication with external service
• Changes permissions or workflow
• Requires SSPP updates

Reviewer Reminders

• Reviewed code changes
• Reviewed functionality
• Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

1. Go to the USAGov Circle CI project.
2. Find the commit of this pull request.
3. Build and deploy the changes.
4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

[akf]

The only thing I found broken is that bin/includes/preamble.sh fails if there is no argument provided to the script (and it is definitely valid to provide no argument to, at least, bin/cloudgov/deploy-waf).

The rest of my comments are documentation tweaks. I didn't test each and every script, but I did a few.

[akf]

bin/cloudgov/deploy-waf (with no arguments) still doesn't work for me. See my comments on bin/includes/preamble.sh.