💡 [patch] WriteThroughCache: cautionary JSDoc #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Self-explanatory, as reminder of what we learned.
ronjouch
commented
Aug 21, 2024
| @@ -4,7 +4,31 @@ import { LocalCache } from './LocalCache'; | |||
|
|
|||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Reminder that cachette is public, no disclosing world domination plans in PR comments.
gregsavoie
approved these changes
Aug 21, 2024
src/lib/WriteThroughCache.ts
Outdated
| * | ||
| * -> This is fixable, e.g. using Redis pub/sub, to let clients subscribe to | ||
| * set/del events, and react with an eviction from their LocalCache. | ||
| * In the context we cachette maintainers got bitten by this, it made sense |
There was a problem hiding this comment.
Are you sure? This sounds funny when I read it
Suggested change
| * In the context we cachette maintainers got bitten by this, it made sense | |
| * We cachette maintainers got bitten by this, and it made sense |
There was a problem hiding this comment.
👍 was weird, I tend to over-omit some liaison words. Fixed in 5280a24.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self-explanatory, as reminder/warning of what we learned.