💡 [patch] Repo maintenance: deps upgrades #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronjouch
commented
Aug 6, 2024
| @@ -60,7 +60,6 @@ export class RedisCache extends CacheInstance { | |||
| // This prevents get/setValue calls from hanging if there is no active connection | |||
| enableOfflineQueue: false, | |||
| }); | |||
| this.redisClient.scan | |||
There was a problem hiding this comment.
Must have been a cat walking on keyboard 😉 . Thankfully, was not doing anything.
- Introduced in this repo maintenance
- Noticed as fishy here by the new ESLint 🙂.
ronjouch
force-pushed
the
repo-maintenance
branch
from
4015741
to
94c8454
Compare
ronjouch
commented
Aug 6, 2024
| @@ -0,0 +1,29 @@ | |||
| import eslint from '@eslint/js'; | |||
There was a problem hiding this comment.
Reminder to reviewers: Cachette is public, no revealing internal sikrit world domination plans here in comments. 🙏
gregsavoie
approved these changes
Aug 6, 2024
ianfdk
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usual:
How was this tested?
Tests & linter pass