🐛 [patch] RedisCache: broaden reconnectOnError condition #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suspect that the current `reconnectOnError` callback doing a `message.startsWith` fails to trigger in cases where the `READONLY` keyword isn't at the beginning of the message. Sadly, this is only a suspicion, as I haven't been able to reproduce cases of failure to reconnect (observed in prod) in local tests triggering a `FAILOVER` Regardless, switching to `includes` ... - Is what's recommended by https://github.com/redis/ioredis#reconnect-on-error - Is risk-free - *May* help in prod/staging (will test after this gets merged) , so here's a PR doing so.
ianfdk
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect that the current
reconnectOnErrorcallback doing amessage.startsWithfails to trigger in cases where theREADONLYkeyword isn't at the beginning of the errormessage.Sadly, this is only a suspicion, as I haven't been able to reproduce cases of failure to reconnect (observed in prod) in local tests triggering a
FAILOVERRegardless, switching to
includes..., so here's a PR doing so.