Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add more tests & fix issues found by them #1879

Open
wants to merge 38 commits into
base: staging
Choose a base branch
from
Open

feat: Add more tests & fix issues found by them #1879

wants to merge 38 commits into from

Conversation

craciunoiuc
Copy link
Member

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran make fmt on your commit series before opening this PR;
  • Updated relevant documentation.

Description of changes

@craciunoiuc craciunoiuc force-pushed the craciunoiuc/add-more-instance-tests branch from 3c2277d to bc12299 Compare September 6, 2024 11:42
@craciunoiuc craciunoiuc changed the title feat: Add tests for rest of instance commands & fix issues feat: Add more tests & fix issues found by them Sep 13, 2024
@craciunoiuc craciunoiuc force-pushed the craciunoiuc/add-more-instance-tests branch from bc12299 to 3b257e3 Compare September 13, 2024 14:40
@craciunoiuc craciunoiuc force-pushed the craciunoiuc/add-more-instance-tests branch from 3b257e3 to 0487008 Compare September 16, 2024 14:08
@craciunoiuc
feat(test): Add tests for 'cloud instance logs'
b447662 
Signed-off-by: Cezar Craciunoiu <[email protected]>
@craciunoiuc
feat(test): Add tests for 'cloud instance remove'
c7d5812 
Signed-off-by: Cezar Craciunoiu <[email protected]>
@craciunoiuc
feat(test): Add tests for 'cloud instance start'
5abe51a 
Signed-off-by: Cezar Craciunoiu <[email protected]>
@craciunoiuc
feat(test): Add tests for 'cloud instance stop'
7d0ad35 
Signed-off-by: Cezar Craciunoiu <[email protected]>
@craciunoiuc
feat(test): Rename test suite to 'cloud'
3e50436 
Signed-off-by: Cezar Craciunoiu <[email protected]>
@craciunoiuc
fix(test): Remove instance after running test
a441f08 
Signed-off-by: Cezar Craciunoiu <[email protected]>
@craciunoiuc
fix(cloud): Allow no arguments to use '--all'
2642972 
Signed-off-by: Cezar Craciunoiu <[email protected]>
@craciunoiuc
fix(cloud): Remove unused flag
ca103b0 
Signed-off-by: Cezar Craciunoiu <[email protected]>
@craciunoiuc
fix(cloud): Swap flag descriptions
e4e3161 
Signed-off-by: Cezar Craciunoiu <[email protected]>
@craciunoiuc
feat(test): Add tests for 'cloud quotas'
125fecf 
Signed-off-by: Cezar Craciunoiu <[email protected]>
@craciunoiuc
feat(test): Add tests for 'cloud metro list'
45dd5db 
Signed-off-by: Cezar Craciunoiu <[email protected]>
@craciunoiuc
feat(test): Add tests for 'cloud volume attach'
480c09f 
Signed-off-by: Cezar Craciunoiu <[email protected]>
@craciunoiuc
feat(test): Add tests for 'cloud volume detach'
97c4221 
Signed-off-by: Cezar Craciunoiu <[email protected]>
@craciunoiuc
feat(test): Add tests for 'cloud volume create'
4243f3b 
Signed-off-by: Cezar Craciunoiu <[email protected]>
@craciunoiuc
feat(test): Add tests for 'cloud volume delete'
4a6a3f0 
Signed-off-by: Cezar Craciunoiu <[email protected]>
@craciunoiuc
feat(test): Add tests for 'cloud volume get'
b40cf45 
Signed-off-by: Cezar Craciunoiu <[email protected]>
@craciunoiuc
feat(test): Add tests for 'cloud volume list'
18b58bb 
Signed-off-by: Cezar Craciunoiu <[email protected]>
@craciunoiuc
fix(cloud): Allow multiple volume arguments
8c6564b 
Signed-off-by: Cezar Craciunoiu <[email protected]>
@craciunoiuc
fix(cloud): Remove unused flag from volume listing
1cc0ef0 
Signed-off-by: Cezar Craciunoiu <[email protected]>
@craciunoiuc craciunoiuc force-pushed the craciunoiuc/add-more-instance-tests branch from 0487008 to 1cc0ef0 Compare September 16, 2024 14:21
@craciunoiuc craciunoiuc force-pushed the craciunoiuc/add-more-instance-tests branch from 0ce847a to b99f458 Compare September 18, 2024 10:08
@craciunoiuc craciunoiuc force-pushed the craciunoiuc/add-more-instance-tests branch from b99f458 to 3831109 Compare September 18, 2024 11:42
@craciunoiuc
feat(test): Add tests for 'cloud volume import'
f13d21b 
Also add test fixtures for working with cpio archives.

Signed-off-by: Cezar Craciunoiu <[email protected]>
@craciunoiuc
fix(cloud): Add state check on importing to allow volume detach
8903b43 
Signed-off-by: Cezar Craciunoiu <[email protected]>
@craciunoiuc
feat(test): Add tests for 'cloud service create'
66001bd 
Signed-off-by: Cezar Craciunoiu <[email protected]>
@craciunoiuc craciunoiuc force-pushed the craciunoiuc/add-more-instance-tests branch from 3831109 to 66001bd Compare September 18, 2024 15:26
@craciunoiuc
feat(test): Add tests for 'cloud service list'
f8c6669 
Signed-off-by: Cezar Craciunoiu <[email protected]>
@craciunoiuc
feat(test): Add tests for 'cloud service get'
75b0da6 
Signed-off-by: Cezar Craciunoiu <[email protected]>
@craciunoiuc
feat(test): Add tests for 'cloud service remove'
cac3b12 
Signed-off-by: Cezar Craciunoiu <[email protected]>
@craciunoiuc
fix(cloud): Remove unused flag from service listing
ac9d5f3 
Signed-off-by: Cezar Craciunoiu <[email protected]>
@craciunoiuc
fix(cloud): Allow additional arguments to service getting
2478d37 
Signed-off-by: Cezar Craciunoiu <[email protected]>
@craciunoiuc
fix(cloud): Warn instead of failing when removing
96b1bdb 
When using the '--all' flag when removing instances
warn of the ignored instances and remove the rest,
instead of failing everything.

Signed-off-by: Cezar Craciunoiu <[email protected]>
@craciunoiuc
feat(test): Add tests for 'cloud tunnel'
6e922d2 
Signed-off-by: Cezar Craciunoiu <[email protected]>
@craciunoiuc
Copy link
Member Author

TODO: wait_timeout_ms to be renamed to timeout_s

Need to change commit: 8903b43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nderjung nderjung Awaiting requested review from nderjung

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@craciunoiuc