feat: Use remote OCI image references as rootfs element #1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nderjung
force-pushed
the
nderjung/feat/initrd/ociimage
branch
5 times, most recently
from
b5d9e9d
to
1fb48ed
Compare
|
Pipeline is failing due to a different cause, fixed in #1631. |
nderjung
force-pushed
the
nderjung/feat/initrd/ociimage
branch
2 times, most recently
from
de42a67
to
4ce7f11
Compare
craciunoiuc
reviewed
May 7, 2024
nderjung
force-pushed
the
nderjung/feat/initrd/ociimage
branch
2 times, most recently
from
4351e08
to
620a048
Compare
craciunoiuc
reviewed
May 7, 2024
nderjung
force-pushed
the
nderjung/feat/initrd/ociimage
branch
8 times, most recently
from
17e2ce5
to
d68458d
Compare
|
@nderjung you'll have to rebase again :D |
This commit makes it possible to specify a remote OCI image as a rootfs. This prevents having to use BuildKit in order to retrieve the rootfs, which has become a common operation. Signed-off-by: Alexander Jung <[email protected]>
nderjung
force-pushed
the
nderjung/feat/initrd/ociimage
branch
from
d68458d
to
5cb57ad
Compare
craciunoiuc
approved these changes
May 13, 2024
There was a problem hiding this comment.
All good here. Thanks!
Reviewed-by: Cezar Craciunoiu [email protected]
Approved-by: Cezar Craciunoiu [email protected]
nderjung
added a commit
to nderjung/kraftkit
that referenced
this pull request
May 13, 2024
The PR unikraft#1630 accidentally overwrote the changes from unikraft#1646. This commit reverts this mistake. Signed-off-by: Alexander Jung <[email protected]>
4 tasks
nderjung
added a commit
to nderjung/kraftkit
that referenced
this pull request
May 13, 2024
…#1646. This commit reverts this mistake. Signed-off-by: Alexander Jung <[email protected]>
nderjung
added a commit
to nderjung/kraftkit
that referenced
this pull request
May 13, 2024
The PR unikraft#1630 accidentally overwrote the changes from unikraft#1646. This commit reverts this mistake. Signed-off-by: Alexander Jung <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
make fmton your commit series before opening this PR;Description of changes
This PR makes it possible to specify a remote OCI image as a rootfs. This prevents having to use BuildKit in order to retrieve the rootfs, which has become a common operation.