fix(cloud): Warn instead of failing when removing

When using the '--all' flag when removing instances warn of the ignored instances and remove the rest, instead of failing everything. Signed-off-by: Cezar Craciunoiu <[email protected]>
unikraft · Sep 19, 2024 · 96b1bdb · 96b1bdb
1 parent 2478d37
commit 96b1bdb
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/internal/cli/kraft/cloud/service/remove/remove.go b/internal/cli/kraft/cloud/service/remove/remove.go
@@ -111,8 +111,17 @@ func Remove(ctx context.Context, opts *RemoveOptions, args ...string) error {
 		}
 
 		args = []string{}
+		attachedInstances := []string{}
 		for _, sgItem := range sgList {
-			args = append(args, sgItem.Name)
+			if sgItem.Instances != nil && len(sgItem.Instances) > 0 {
+				attachedInstances = append(attachedInstances, sgItem.Name)
+			} else {
+				args = append(args, sgItem.Name)
+			}
+		}
+
+		if len(attachedInstances) > 0 {
+			log.G(ctx).Warnf("ignoring %d service(s) as instances are attached: %v", len(attachedInstances), attachedInstances)
 		}
 	}