Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add docs English #11520

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs: add docs English #11520

wants to merge 1 commit into from

Conversation

thodinh
Copy link

@thodinh thodinh commented Aug 15, 2023

Add document for English

@thodinh thodinh changed the title feat(docs): add docs English docs: add docs English Aug 15, 2023
@vercel
Copy link

vercel bot commented Aug 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
umi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2023 6:32pm

@PeachScript
Copy link
Member

感谢花费大量时间贡献英文版本的文档 ❤️

但很抱歉的是,Umi 刚合并了迁移文档方案到 dumi 的 PR,从 .mdx.md 会有一些语法调整,所以该 PR 的内容和 master 产生了冲突;如果你有时间的话看看是否愿意基于 master 分支重新调整该 PR,工作量估计不小,另外建议直接将中文作为默认语言,避免现有用户受到影响

@thodinh
Copy link
Author

thodinh commented Aug 16, 2023

感谢花费大量时间贡献英文版本的文档 ❤️

但很抱歉的是,Umi 刚合并了迁移文档方案到 dumi 的 PR,从 .mdx.md 会有一些语法调整,所以该 PR 的内容和 master 产生了冲突;如果你有时间的话看看是否愿意基于 master 分支重新调整该 PR,工作量估计不小,另外建议直接将中文作为默认语言,避免现有用户受到影响

Ok, let me update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants