Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle %OAuth2.Response{status_code: 503} with no error_description in get_access_token #99

Merged
merged 4 commits into from
Aug 3, 2023
Merged

Handle %OAuth2.Response{status_code: 503} with no error_description in get_access_token #99

merged 4 commits into from
Aug 3, 2023

Conversation

angelikatyborska
Copy link
Contributor

@angelikatyborska angelikatyborska commented Aug 2, 2023 •
edited by yordis
Loading

closes #98

@angelikatyborska angelikatyborska requested a review from a team as a code owner August 2, 2023 22:42
@yordis
Copy link
Member

yordis commented Aug 3, 2023

@angelikatyborska do you mind adding an entry at https://github.com/ueberauth/ueberauth_google/blob/master/CHANGELOG.md 🙏🏻

@angelikatyborska
Copy link
Contributor Author

Done. I'm addressing the CI failures in another PR because they're unrelated to my changes: #100

@yordis yordis merged commit 2013403 into ueberauth:master Aug 3, 2023
2 checks passed
@angelikatyborska angelikatyborska deleted the handle-503-response-with-no-error-description branch August 4, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yordis yordis yordis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

%OAuth2.Response{status_code: 503} with no error_description in body is not handled in get_access_token
2 participants
@angelikatyborska @yordis