Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scope splitting #104

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Fix scope splitting #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0221915
Fix scope splitting
aptinio Nov 13, 2023
5454e68
chore: add changelog
aptinio Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 26 additions & 22 deletions CHANGELOG.md
View file
Open in desktop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yordis, I didn't realize until now that my editor formatted this file (using Prettier). Sorry about that 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, it is not your fault. I need to put Actions in place that helps with these things honestly

Original file line number Diff line number Diff line change
Expand Up @@ -2,67 +2,71 @@

## (Unreleased)

## v0.12.1

- Fix scope splitting [104](https://github.com/ueberauth/ueberauth_google/pull/104)

## v0.12.0

* Add support to hl param in handle_request! [102](https://github.com/ueberauth/ueberauth_google/pull/102)
- Add support to hl param in handle_request! [102](https://github.com/ueberauth/ueberauth_google/pull/102)

## v0.11.0

* Allow using a function to generate the client secret [101](https://github.com/ueberauth/ueberauth_google/pull/101)
- Allow using a function to generate the client secret [101](https://github.com/ueberauth/ueberauth_google/pull/101)

## v0.10.3

* Handle `%OAuth2.Response{status_code: 503}` with no `error_description` in `get_access_token` [99](https://github.com/ueberauth/ueberauth_google/pull/99)
- Handle `%OAuth2.Response{status_code: 503}` with no `error_description` in `get_access_token` [99](https://github.com/ueberauth/ueberauth_google/pull/99)

## v0.10.2

* Prefer Local Over Global Configuration [95](https://github.com/ueberauth/ueberauth_google/pull/95)
- Prefer Local Over Global Configuration [95](https://github.com/ueberauth/ueberauth_google/pull/95)

## v0.10.1

* Misc doc changes [81](https://github.com/ueberauth/ueberauth_google/pull/81)
* Upgrade Ueberauth and Refactor CSRF State Logic [82](https://github.com/ueberauth/ueberauth_google/pull/82)
- Misc doc changes [81](https://github.com/ueberauth/ueberauth_google/pull/81)
- Upgrade Ueberauth and Refactor CSRF State Logic [82](https://github.com/ueberauth/ueberauth_google/pull/82)

## v0.10.0 - 2020-10-20

### Enhancement

* Updated docs [#69](https://github.com/ueberauth/ueberauth_google/pull/69) [#70](https://github.com/ueberauth/ueberauth_google/pull/70)
* Support for birthday [#73](https://github.com/ueberauth/ueberauth_google/pull/73)
* Allow for userinfo endpoint to be configured [#75](https://github.com/ueberauth/ueberauth_google/pull/75)
* Updated plug and ueberauth packages [#76](https://github.com/ueberauth/ueberauth_google/pull/76)
- Updated docs [#69](https://github.com/ueberauth/ueberauth_google/pull/69) [#70](https://github.com/ueberauth/ueberauth_google/pull/70)
- Support for birthday [#73](https://github.com/ueberauth/ueberauth_google/pull/73)
- Allow for userinfo endpoint to be configured [#75](https://github.com/ueberauth/ueberauth_google/pull/75)
- Updated plug and ueberauth packages [#76](https://github.com/ueberauth/ueberauth_google/pull/76)

Thanks goes to all the contributes

## v0.9.0 - 2019-08-21

### Enhancement

* Add support for optional login_hint param [#61](https://github.com/ueberauth/ueberauth_google/pull/61)
* Use `json_library` method from Ueberauth config [#58](https://github.com/ueberauth/ueberauth_google/pull/58)
* Allows specifying `{m, f, a}` tuples for things such as Client ID
- Add support for optional login_hint param [#61](https://github.com/ueberauth/ueberauth_google/pull/61)
- Use `json_library` method from Ueberauth config [#58](https://github.com/ueberauth/ueberauth_google/pull/58)
- Allows specifying `{m, f, a}` tuples for things such as Client ID
and Client Secret [#60](https://github.com/ueberauth/ueberauth_google/pull/60)
* Allows the newest oauth2 package versions with potential security fixes [#68](https://github.com/ueberauth/ueberauth_google/pull/68)
- Allows the newest oauth2 package versions with potential security fixes [#68](https://github.com/ueberauth/ueberauth_google/pull/68)

## v0.6.0 - 2017-07-18

* Add support for `access_type` per request using `url` parameter.
- Add support for `access_type` per request using `url` parameter.

## v0.5.0 - 2016-12-27

* Add support for new params: `access_type`, `approval_prompt`, `state`.
* Fix Elixir warnings.
- Add support for new params: `access_type`, `approval_prompt`, `state`.
- Fix Elixir warnings.

## v0.4.0 - 2016-09-21

* Target Elixir 1.3 and greater.
* Fix OAuth bug with 0.6.0 pin.
- Target Elixir 1.3 and greater.
- Fix OAuth bug with 0.6.0 pin.

## v0.3.0 - 2016-08-15

* Use OpenID endpoint for profile information.
* Update authorize and token URLs.
- Use OpenID endpoint for profile information.
- Update authorize and token URLs.

## v0.2.0 - 2016-12-10

* Release 0.2.0 to follow Ueberauth.
- Release 0.2.0 to follow Ueberauth.
2 changes: 1 addition & 1 deletion lib/ueberauth/strategy/google.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ defmodule Ueberauth.Strategy.Google do
def credentials(conn) do
token = conn.private.google_token
scope_string = token.other_params["scope"] || ""
scopes = String.split(scope_string, ",")
scopes = String.split(scope_string, " ")

%Credentials{
expires: !!token.expires_at,
Expand Down
2 changes: 1 addition & 1 deletion mix.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ defmodule UeberauthGoogle.Mixfile do
use Mix.Project

@source_url "https://github.com/ueberauth/ueberauth_google"
@version "0.12.0"
@version "0.12.1"

def project do
[
Expand Down
Loading