Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for mesh powerstrap #845

Merged
merged 10 commits into from
Apr 11, 2024
Merged

support for mesh powerstrap #845

merged 10 commits into from
Apr 11, 2024

Conversation

yolowiz
Copy link
Contributor

@yolowiz yolowiz commented Mar 6, 2024

Related PRs / Issues

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • Change to core Hammer
  • Change to a Hammer plugin
  • Other

Contributor Checklist:

  • Did you set master as the base branch?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you update the poetry.lock file if you updated the requirements in pyproject.toml?
  • (If applicable) Did you add a unit test demonstrating the PR?
  • (If applicable) Did you run this through the e2e integration tests?
  • (If applicable) Did you update the submodules in e2e/ if this feature depends on updated plugins?

Copy link
Contributor

@harrisonliew harrisonliew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the documentation with a diagram using this new method? I'd like to see whether the utilization property makes sense (recommend 0.2 for diagram).

@harrisonliew harrisonliew added this pull request to the merge queue Apr 11, 2024
Merged via the queue into master with commit 1f3611f Apr 11, 2024
4 checks passed
@harrisonliew harrisonliew deleted the mesh-strap branch April 11, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants