Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SPICE tools #439

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Add SPICE tools #439

wants to merge 10 commits into from

Conversation

jwright6323
Copy link
Contributor

This adds SPICE tools to hammer_utils. Specifically the ones added are for uniquifying colliding names in groups of SPICE files.

@jwright6323 jwright6323 added DeveloperSupport These are issues that help developers of plugins and core hammer not users. enhancement medium priority Hard workaround exists, costing time/effort, chip QoL/QoR issue labels Jun 14, 2019
edwardcwang
edwardcwang approved these changes Jun 14, 2019
View reviewed changes
Copy link
Member

@edwardcwang edwardcwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM modulo a few suggested changes. I actually wrote a hacky version of this before...

src/hammer-vlsi/hammer_utils/spice_utils.py Outdated Show resolved Hide resolved
src/hammer-vlsi/hammer_utils/spice_utils.py Outdated Show resolved Hide resolved
src/hammer-vlsi/hammer_utils/spice_utils.py Show resolved Hide resolved
@jwright6323
Copy link
Contributor Author

Thanks for the quick review @edwardcwang ! I'm going to hold off on clicking the button in case we want to make some changes with ucb-bar/hammer-cad-plugins#118.

@jwright6323 jwright6323 added the CurrentTapeout This issue is needed for an ongoing tapeout at UCB label Jun 19, 2019
@jwright6323
Copy link
Contributor Author

Removing the CurrentTapeout tag- I think we're going to punt on this.

@jwright6323 jwright6323 removed the CurrentTapeout This issue is needed for an ongoing tapeout at UCB label Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardcwang edwardcwang edwardcwang approved these changes

@colinschmidt colinschmidt Awaiting requested review from colinschmidt

Assignees
No one assigned
Labels
DeveloperSupport These are issues that help developers of plugins and core hammer not users. enhancement medium priority Hard workaround exists, costing time/effort, chip QoL/QoR issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwright6323 @edwardcwang