Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle 'None' string in fence config #1161

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Handle 'None' string in fence config #1161

wants to merge 24 commits into from

Conversation

AlbertSnows
Copy link
Contributor

@AlbertSnows AlbertSnows commented Jul 18, 2024 •
edited
Loading

Link to JIRA ticket if there is one: https://ctds-planx.atlassian.net/browse/PXP-11305

New Features

Breaking Changes

Bug Fixes

  • fixed initial setup error due to empty property in config-default.yaml file

Improvements

Dependency updates

Deployment changes

@AlbertSnows AlbertSnows changed the title [WIP] Fix/handle none string v2 Handle 'None' string in fence config Jul 18, 2024
@AlbertSnows AlbertSnows marked this pull request as ready for review July 18, 2024 19:13
mfshao
mfshao reviewed Jul 18, 2024
View reviewed changes
fence/config.py Outdated Show resolved Hide resolved
AlbertSnows and others added 5 commits July 18, 2024 15:06
@AlbertSnows
adding more state handling
ed05a13
@AlbertSnows
Trigger GitHub Actions workflow
7c1ffe4
@k-burt-uch @AlbertSnows
Testing
9ee8a78
@k-burt-uch @AlbertSnows
fix(PXP-11364): Fix failing dbgap sync unit test
174424f 
Fix so local csvs file are processed in consistent order, regardless of os

Updates user_info overwrite logic to preserve data when processing CSVs without
some attributes
@AlbertSnows
Trigger GitHub Actions workflow
532dcc5
@coveralls
Copy link

coveralls commented Jul 23, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10689223869

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 315 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.2%) to 75.487%
Files with Coverage Reduction New Missed Lines %
config.py 12 85.39%
utils.py 55 64.81%
scripting/google_monitor.py 103 40.0%
scripting/fence_create.py 145 61.66%
Totals Coverage Status
Change from base Build 10618407452: 0.2%
Covered Lines: 7834
Relevant Lines: 10378
💛 - Coveralls

Avantol13
Avantol13 requested changes Jul 23, 2024
View reviewed changes
tests/test_app_config.py Show resolved Hide resolved
@AlbertSnows AlbertSnows changed the title Handle 'None' string in fence config Handle 'None' string in fence config Jul 31, 2024
BinamB
BinamB previously approved these changes Aug 7, 2024
View reviewed changes
Avantol13
Avantol13 requested changes Aug 7, 2024
View reviewed changes
fence/config.py Outdated Show resolved Hide resolved
fence/config.py Outdated Show resolved Hide resolved
fence/config.py Outdated Show resolved Hide resolved
tests/test_app_config.py Show resolved Hide resolved
tests/test_app_config.py Show resolved Hide resolved
fence/config.py Outdated Show resolved Hide resolved
Avantol13
Avantol13 requested changes Aug 9, 2024
View reviewed changes
fence/config.py Outdated Show resolved Hide resolved
fence/config.py Outdated Show resolved Hide resolved
tests/test_app_config.py Show resolved Hide resolved
@AlbertSnows
more documentation
a06ecaf 
minor refactors
implementing alex's suggestions
Avantol13
Avantol13 requested changes Aug 9, 2024
View reviewed changes
fence/config.py Outdated Show resolved Hide resolved
fence/config.py Outdated Show resolved Hide resolved
fence/config.py Outdated Show resolved Hide resolved
fence/config.py Outdated Show resolved Hide resolved
fence/config.py Outdated Show resolved Hide resolved
@AlbertSnows
more documentation
2b63f57 
changes to visibility
@AlbertSnows
Merge remote-tracking branch 'origin/fix/handle_none_string_v2' into …
95db2db 
…fix/handle_none_string_v2
@AlbertSnows
cleaning up references in test fence create
8e60f67 
moving create_client to fence create to help resolve circular dependencies
defining generic functions in config
moving send email to google monitor to help with circular dependencies
adding utils test
@AlbertSnows
Merge branch 'master' into fix/handle_none_string_v2
528feac
@AlbertSnows
documentation + minor rename
06cebff
Avantol13
Avantol13 requested changes Aug 26, 2024
View reviewed changes
tests/test_utils.py Show resolved Hide resolved
tests/test_utils.py Outdated Show resolved Hide resolved
fence/utils.py Show resolved Hide resolved
fence/utils.py Show resolved Hide resolved
fence/utils.py Show resolved Hide resolved
@AlbertSnows AlbertSnows mentioned this pull request Sep 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfshao mfshao mfshao left review comments

@Avantol13 Avantol13 Avantol13 requested changes

@BinamB BinamB BinamB left review comments

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@AlbertSnows @coveralls @mfshao @Avantol13 @BinamB @PlanXCyborg @k-burt-uch