[RFC] PAM: Build GDM support only on the library #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to make it optional in next steps
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #566 +/- ##
==========================================
- Coverage 84.53% 84.53% -0.01%
==========================================
Files 79 82 +3
Lines 7036 7048 +12
Branches 75 75
==========================================
+ Hits 5948 5958 +10
- Misses 759 761 +2
Partials 329 329 ☔ View full report in Codecov by Sentry. |
3v1n0
force-pushed
the
module-gdm-split
branch
3 times, most recently
from
18557f3
to
521bae5
Compare
We don't really use all the gdm-related code in the PAM Exec child that we use in normal PAM transactions, so no need to compile it at all by default while we need it in the PAM library that GDM will consume.
3v1n0
force-pushed
the
module-gdm-split
branch
from
521bae5
to
6702205
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's quite a bit of code that is GDM related that we don't really need to include into the compiled PAM binary that we use for authentication in non-GDM cases.
We don't really use all the gdm-related code in the PAM Exec child that
we use in normal PAM transactions, so no need to compile it at all by
default while we need it in the PAM library that GDM will consume.
This is basically the opposite of #292, as that tried to unify the logic while here we assumed that we're going to ship two different implementations, and so reducing the logic in one side when is not needed.