feat: add dropdown for category filter #1334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
d-loose
commented
Aug 15, 2023
d-loose
commented
- Exposes the category filter, introduced in feat: generalize search provider to support 'category' #1324, as a dropdown on the search result page
- Generalizes the search provider mocks accordingly and adds new test cases
| @@ -40,6 +40,11 @@ enum SnapCategoryEnum { | |||
| utilities, | |||
| unknown; | |||
|
|
|||
| bool get hidden => switch (this) { | |||
There was a problem hiding this comment.
Is not this switch an overkill over a trivial Boolean expression? Even considering that the list of values resulting in true can grow, it will still be a one-liner conjunction expression.
There was a problem hiding this comment.
Totally :D
I'll add at least one more 'hidden' category in the near future, but this can still be simplified a little - thanks
CarlosNihelton
approved these changes
Aug 15, 2023
d-loose
force-pushed
the
category-dropdown
branch
from
8a83dc3
to
5f85651
Compare
kenvandine
pushed a commit
that referenced
this pull request
Aug 15, 2023
* add l10n strings * add 'hidden' property to SnapCategoryEnum * add category dropdown to search page * generalize mockSearchProvider * test category search * simplify 'hidden' property
tim-hm
pushed a commit
to tim-hm/app-center
that referenced
this pull request
Sep 1, 2023
* add l10n strings * add 'hidden' property to SnapCategoryEnum * add category dropdown to search page * generalize mockSearchProvider * test category search * simplify 'hidden' property
tim-hm
pushed a commit
to tim-hm/app-center
that referenced
this pull request
Sep 1, 2023
* add l10n strings * add 'hidden' property to SnapCategoryEnum * add category dropdown to search page * generalize mockSearchProvider * test category search * simplify 'hidden' property
ashuntu
pushed a commit
to ashuntu/app-center
that referenced
this pull request
Feb 28, 2024
* add l10n strings * add 'hidden' property to SnapCategoryEnum * add category dropdown to search page * generalize mockSearchProvider * test category search * simplify 'hidden' property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.