feat(manage): show progress in 'update all' button #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
d-loose
commented
Aug 15, 2023
d-loose
commented
- Disable refresh button when an update is in progress
- Disable 'update all' button while checking for updates
- Show progress indicator in the 'update all' button during an update (similar to the primary action button on the detail page)
CarlosNihelton
approved these changes
Aug 15, 2023
lib/src/manage/manage_page.dart
Outdated
| onPressed: ref.read(updatesModelProvider).refresh, | ||
| onPressed: updatesModel.activeChangeId != null | ||
| ? null | ||
| : ref.read(updatesModelProvider).refresh, |
There was a problem hiding this comment.
Honest question: you cannot reuse the updatesModel local variable because it was created with ref.watch, can you?
There was a problem hiding this comment.
Oh, you totally can, thanks for spotting!
It's just a force of habit to always use read when calling methods on a provider
| child: updatesModel.activeChangeId != null | ||
| ? Consumer( | ||
| builder: (context, ref, child) { | ||
| final change = ref |
There was a problem hiding this comment.
Another honest question: change can never be null if updatesModel.activeChangeId is not null, can it?
There was a problem hiding this comment.
Just to double check my understanding.
There was a problem hiding this comment.
It's null while the changeProvider, which gives an AsyncValue<SnapdChange>, is fetching the data from snapd
kenvandine
pushed a commit
that referenced
this pull request
Aug 15, 2023
* move snap l10n extensions into separate file * show change progress in 'update all' button * update tests, leave todo notes * add 'updating' l10n string * re-use updatesModel
tim-hm
pushed a commit
to tim-hm/app-center
that referenced
this pull request
Sep 1, 2023
* move snap l10n extensions into separate file * show change progress in 'update all' button * update tests, leave todo notes * add 'updating' l10n string * re-use updatesModel
tim-hm
pushed a commit
to tim-hm/app-center
that referenced
this pull request
Sep 1, 2023
* move snap l10n extensions into separate file * show change progress in 'update all' button * update tests, leave todo notes * add 'updating' l10n string * re-use updatesModel
ashuntu
pushed a commit
to ashuntu/app-center
that referenced
this pull request
Feb 28, 2024
* move snap l10n extensions into separate file * show change progress in 'update all' button * update tests, leave todo notes * add 'updating' l10n string * re-use updatesModel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.