feat: add 'Discover more' button to banners #1332
Conversation
| Row( | ||
| mainAxisSize: MainAxisSize.min, | ||
| children: snaps.map((snap) => _BannerIcon(snap: snap)).toList(), | ||
| ), |
There was a problem hiding this comment.
Can we animate the appearance of the row? Did Design suggested anything to smooth the appearance of those icon buttons?
There was a problem hiding this comment.
Currently we're very much focused on the 'M' in 'MVP' :D - we're planning to polish the UI a bit more after the initial release - I'll add some TODO notes!
| final String? buttonLabel; | ||
| final VoidCallback? onPressed; | ||
|
|
||
| static const _kForegroundColor = Colors.white; |
There was a problem hiding this comment.
This constant plays nice with the current selection of banner gradients in both light and dark modes. If eventually a new design arises that breaks that, we'd need the foreground color dependent on the gradient colors, thus IMHO I think we should accept it as a parameter of the widget's constructor even though it will default to this particular value for now.
There was a problem hiding this comment.
Thanks - I completely agree. I'm planning to refactor all the private Widgets in that file into their own files, once the design is settled (there'll be tests and no fewer hardcoded values!). Would you be happy with a 'TODO' plan in the code? :)
|
@CarlosNihelton, sorry - should've made clearer that we're still working on rather short and small UI iterations with lots of loose ends |
That's fine. Even though we may have a very complete backlog somewhere else (as GH issues or JIRA cards etc) I still consider the inline comments of great value to show others that happen to be reviewing the code (this is open source, after all) that we considered some aspects of the current implementation and avoid certain kinds of questions. |
|
Thanks a lot, that's good advice :) |
d-loose
force-pushed
the
banner-buttons
branch
from
5d8697a
to
be431b1
Compare
* add l10n strings * add button to banner * hide banner icons in small layout * add todo notes
* add l10n strings * add button to banner * hide banner icons in small layout * add todo notes
* add l10n strings * add button to banner * hide banner icons in small layout * add todo notes
* add l10n strings * add button to banner * hide banner icons in small layout * add todo notes
Screencast.from.2023-08-14.16-58-46.webm
The button label can be customized for each category. Since the button might need a lot of horizontal space - hide the three snap icons in the narrow layout.