feat: add 'show details' action to manage page #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just a single item in the dropdown for the MVP
jpnurmi
approved these changes
Aug 10, 2023
lib/src/manage/manage_page.dart
Outdated
Comment on lines
306
to
312
| onPressed: () { | ||
| if (controller.isOpen) { | ||
| controller.close(); | ||
| } else { | ||
| controller.open(); | ||
| } | ||
| }, |
There was a problem hiding this comment.
I just realized that one could get away without allocating a closure ;)
onPressed: controller.isOpen ? controller.close : controller.open,
tim-hm
pushed a commit
to tim-hm/app-center
that referenced
this pull request
Sep 1, 2023
* feat: add 'show details' action to manage page Just a single item in the dropdown for the MVP * simplify 'onPressed'
tim-hm
pushed a commit
to tim-hm/app-center
that referenced
this pull request
Sep 1, 2023
* feat: add 'show details' action to manage page Just a single item in the dropdown for the MVP * simplify 'onPressed'
ashuntu
pushed a commit
to ashuntu/app-center
that referenced
this pull request
Feb 28, 2024
* feat: add 'show details' action to manage page Just a single item in the dropdown for the MVP * simplify 'onPressed'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UDENG-1048
Just a single item in the dropdown for the MVP
Screencast.from.2023-08-09.17-45-45.webm