Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert change of gstreamer-plugins #645

Merged
merged 1 commit into from
Oct 6, 2024

Conversation

bsherman
Copy link
Contributor

@bsherman bsherman commented Oct 6, 2024

In PR #636 I was over-eager in changing out "-free" packages which had alternatives in negativo17's fedora-multimedia repo.

Specifically, the gstreamer-plugins provided have a large set of dependencies which increase the size of the "*-main" images by approximately 1GiB. Reverting that change as if a user or downstream wishes it, they can make the change (eg, Bazzite does this I think), but others should not be burdened with this size change, expecially not as part of a PR which was just supposed to swap out the source of some packages.

In PR #636 I was over-eager in changing out "-free" packages which had
alternatives in negativo17's fedora-multimedia repo.

Specifically, the gstreamer-plugins provided have a large set of
dependencies which increase the size of the "*-main" images by
approximately 1GiB. Reverting that change as if a user or downstream
wishes it, they can make the change (eg, Bazzite does this I think), but
others should not be burdened with this size change, expecially not as
part of a PR which was just supposed to swap out the source of some
packages.
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. dependencies Pull requests that update a dependency file labels Oct 6, 2024
Copy link
Member

@m2Giles m2Giles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be set in bluefin/bazzite!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Oct 6, 2024
@bsherman bsherman added this pull request to the merge queue Oct 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 6, 2024
@bsherman bsherman merged commit ca6f6e5 into main Oct 6, 2024
18 checks passed
@bsherman bsherman deleted the revert-gstreamer-plugin-change branch October 6, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants