Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build and test SwiftUI-MVVM app in ci #471

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Build and test SwiftUI-MVVM app in ci #471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,7 @@ jobs:
run: xcodebuild test -project Sample/Pluginized/TicTacToe/TicTacToe.xcodeproj -scheme ScoreSheetTests -destination 'platform=iOS Simulator,OS=16.1,name=iPhone 14'
- name: "NeedleSamplePluginizedTicTacToeCoreTests"
run: xcodebuild test -project Sample/Pluginized/TicTacToe/TicTacToe.xcodeproj -scheme TicTacToeCoreTests -destination 'platform=iOS Simulator,OS=16.1,name=iPhone 14'
- name: "NeedleSampleSwiftUIMVVMApp"
run: xcodebuild build -project Sample/SwiftUI-MVVM/TicTacToe/TicTacToe.xcodeproj -scheme TicTacToe -destination 'platform=iOS Simulator,OS=16.1,name=iPhone 14'
- name: "NeedleSampleSwiftUIMVVMTests"
run: xcodebuild test -project Sample/SwiftUI-MVVM/TicTacToe/TicTacToe.xcodeproj -scheme TicTacToeTests -destination 'platform=iOS Simulator,OS=16.1,name=iPhone 14'
2 changes: 1 addition & 1 deletion Sample/SwiftUI-MVVM/TicTacToe/Sources/LoggedIn/LoggedInComponent.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import SwiftUI

class LoggedInComponent: Component<EmptyDependency>, LoggedInBuilder {

var scoreStream: ScoreStream {
public var scoreStream: ScoreStream {
return mutableScoreStream
}

Expand Down
5 changes: 3 additions & 2 deletions Sample/SwiftUI-MVVM/TicTacToe/Sources/NeedleGenerated.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,13 +104,14 @@ extension LoggedOutComponent: Registration {
extension LoggedInComponent: Registration {
public func registerItems() {


localTable["scoreStream-ScoreStream"] = { [unowned self] in self.scoreStream as Any }
}
}
extension RootComponent: Registration {
public func registerItems() {


localTable["playersStream-PlayersStream"] = { [unowned self] in self.playersStream as Any }
localTable["mutablePlayersStream-MutablePlayersStream"] = { [unowned self] in self.mutablePlayersStream as Any }
}
}

Expand Down
4 changes: 2 additions & 2 deletions Sample/SwiftUI-MVVM/TicTacToe/Sources/Root/RootComponent.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ import SwiftUI

class RootComponent: BootstrapComponent {

var playersStream: PlayersStream {
public var playersStream: PlayersStream {
return mutablePlayersStream
}

var mutablePlayersStream: MutablePlayersStream {
public var mutablePlayersStream: MutablePlayersStream {
return shared { PlayersStreamImpl() }
}

Expand Down