Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make suspend functions callable inside test(worker) { } #624

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

psteiger
Copy link
Contributor

@psteiger psteiger commented Nov 9, 2023

We don't need crossinline for testBody. Usage of cross-inline makes suspend functions non-callable in the test body, which forbids patterns like:

test(worker) {
  sharedFlow.emit(someValue)
  // assert worker processed it
}

We don't need `crossinline` for `testBody`. Usage of cross-inline makes suspend functions non-callable in the test body, which forbids patterns like:
```
test(worker) {
  sharedFlow.emit(someValue)
  // assert worker processed it
}
```
@FranAguilera FranAguilera self-requested a review November 9, 2023 17:45
@psteiger psteiger merged commit cbd11f7 into uber:main Nov 9, 2023
2 checks passed
@psteiger psteiger deleted the test-worker-inline branch November 9, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants