Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1342 - plainToInstance loses values for the Map type if key matches a prototype value of Map #1343

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fixes #1342 - plainToInstance loses values for the Map type if key matches a prototype value of Map #1343

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a164895
Aims to fix #1342
haug-den-lucas Sep 16, 2022
2ea18a9
Merge branch 'develop' into develop
haug-den-lucas Jan 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/TransformOperationExecutor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ export class TransformOperationExecutor {
// throw new Error(`Cannot determine type for ${(targetType as any).name }.${propertyName}, did you forget to specify a @Type?`);

// if newValue is a source object that has method that match newKeyName then skip it
if (newValue.constructor.prototype) {
if (newValue.constructor.prototype && !(newValue instanceof Map)) {
const descriptor = Object.getOwnPropertyDescriptor(newValue.constructor.prototype, newValueKey);
if (
(this.transformationType === TransformationType.PLAIN_TO_CLASS ||
Expand Down