Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[Fixes #86] Close the HTTP pool when service is stopped." #155

Merged
merged 1 commit into from
Feb 24, 2020

Conversation

glyph
Copy link
Member

@glyph glyph commented Feb 24, 2020

Reverts #140

Fixes #154

@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #155 into master will increase coverage by 0.73%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #155      +/-   ##
========================================
+ Coverage   99.26%   100%   +0.73%     
========================================
  Files          27     27              
  Lines        2044   2000      -44     
  Branches      179    173       -6     
========================================
- Hits         2029   2000      -29     
+ Misses         11      0      -11     
+ Partials        4      0       -4
Impacted Files Coverage Δ
src/txacme/testing.py 100% <ø> (+3.87%) ⬆️
src/txacme/client.py 100% <100%> (+1.85%) ⬆️
src/txacme/test/test_service.py 100% <100%> (ø) ⬆️
src/txacme/test/test_client.py 100% <100%> (ø) ⬆️
src/txacme/endpoint.py 100% <100%> (ø) ⬆️
src/txacme/test/test_endpoint.py 100% <100%> (ø) ⬆️
src/txacme/service.py 100% <100%> (ø) ⬆️
src/txacme/test/test_challenges.py 100% <0%> (+0.94%) ⬆️
src/txacme/challenges/__init__.py 100% <0%> (+28.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f60aae...0bed08a. Read the comment docs.

@glyph glyph merged commit a52fad2 into master Feb 24, 2020
@glyph glyph deleted the revert-140-86-service-stop branch February 24, 2020 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Traceback: exceptions.AttributeError: Deferred instance has no attribute 'register'
1 participant