Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add cli support for some new preview urls #243

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sselvam7
Copy link

@sselvam7 sselvam7 commented Feb 2, 2024

Fixes

Add cli support for some new preview urls from Flex. Also a fix for a null check.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@sselvam7 sselvam7 changed the title feat: Add twilio-cli for some new preview urls feat: Add cli support for some new preview urls Feb 2, 2024
Copy link
Contributor

@tiwarishubham635 tiwarishubham635 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a branch in this repo and add your changes there so that it can access the sonar token secret of this repo.

@@ -2597,6 +2597,309 @@
"nullable": true
}
}
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file need not be changed since these spec files will be overwritten by released spec files from oai. If your changes are there in open-api or api-definitions, they will be coming here as well. No need to do it explicitly here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants