Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added configuration for commonmark use in twig-extra-bundle. #3737

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from

Conversation

doekenorg
Copy link

@doekenorg doekenorg commented Aug 23, 2022

Following this tweet: https://twitter.com/ramsey/status/1561894460560138241, this PR adds the configuration options for commonmark to the twig-extra-bundle.

The configuration is added to the LeagueCommonMarkConverterFactory and in turn injected in the CommonMarkConverter. This way a user can provide the configuration for usage inside twig.

I'm not sure if adding the configuration inside the extension is the way to go.

Hope this helps out at least @ramsey :-)

Added ignoreExtraKeys to be somewhat future proof in case extra configuration is added later on, and also to be able to provide de configuration for extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants