Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace View visibility extensions #3402

Closed
wants to merge 8 commits into from

Conversation

@Goooler
Copy link
Contributor Author

Goooler commented Feb 28, 2023

Seems ktlnt checks passed on my local, we'd better to migrate to new Ktlint version, link #2914.

/bitrise/src/app/src/main/java/com/keylesspalace/tusky/components/account/media/AccountMediaGridAdapter.kt:3:1 Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end
/bitrise/src/app/src/main/java/com/keylesspalace/tusky/components/accountlist/AccountListFragment.kt:18:1 Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end
/bitrise/src/app/src/main/java/com/keylesspalace/tusky/components/announcements/AnnouncementsActivity.kt:18:1 Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end
/bitrise/src/app/src/main/java/com/keylesspalace/tusky/components/instancemute/fragment/InstanceListFragment.kt:3:1 Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end
/bitrise/src/app/src/main/java/com/keylesspalace/tusky/components/report/fragments/ReportDoneFragment.kt:18:1 Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end
/bitrise/src/app/src/main/java/com/keylesspalace/tusky/components/report/fragments/ReportNoteFragment.kt:18:1 Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end
/bitrise/src/app/src/main/java/com/keylesspalace/tusky/components/scheduled/ScheduledStatusActivity.kt:18:1 Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end
/bitrise/src/app/src/main/java/com/keylesspalace/tusky/components/trending/TrendingFragment.kt:18:1 Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end
/bitrise/src/app/src/main/java/com/keylesspalace/tusky/components/viewthread/edits/ViewEditsAdapter.kt:3:1 Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end
/bitrise/src/app/src/main/java/com/keylesspalace/tusky/components/viewthread/edits/ViewEditsFragment.kt:18:1 Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end
/bitrise/src/app/src/main/java/com/keylesspalace/tusky/components/viewthread/ViewThreadFragment.kt:18:1 Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end
/bitrise/src/app/src/main/java/com/keylesspalace/tusky/FiltersActivity.kt:3:1 Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end
/bitrise/src/app/src/main/java/com/keylesspalace/tusky/ListsActivity.kt:19:1 Imports must be ordered in lexicographic order without any empty lines in-between with "java", "javax", "kotlin" and aliases in the end

@Goooler Goooler changed the title Replace View extensions Replace View visibility extensions Mar 1, 2023
@connyduck
Copy link
Collaborator

visible->isVisible ok, but show/hide is my pet peeve I'm very sorry 😬

@Goooler
Copy link
Contributor Author

Goooler commented Mar 2, 2023

I'll handle them in a new PR.

@Goooler Goooler closed this Mar 2, 2023
@Goooler Goooler deleted the replace_view_extensions branch March 2, 2023 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants