SendBatch: Don't start goroutines #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #232 +/- ##
==========================================
- Coverage 70.30% 70.30% -0.01%
==========================================
Files 27 27
Lines 3718 3721 +3
==========================================
+ Hits 2614 2616 +2
+ Misses 989 988 -1
- Partials 115 117 +2
☔ View full report in Codecov by Sentry. |
aaronbee
force-pushed
the
nogobatch
branch
2 times, most recently
from
b980066
to
cd1536b
Compare
|
Testing shows this didn't affect performance, so I think this is worth merging because it simplifies thinking about the cost of a SendBatch. |
ciacono
reviewed
Sep 14, 2023
ciacono
reviewed
Sep 14, 2023
There was a problem hiding this comment.
The idea behind this makes sense to me, although I do see concern with the potential slowdown because we are doing this sequentially. But having the resource usage being more predictable (and less expensive with less goroutines) seems worthwhile. Other than the comment I left, LGTM.
Instead of starting goroutines we can queue each region server's collection of RPCs and only after queueing them all wait for all responses. We get a similar amount of parallelism, the only potential slow down is that we can't queue one region server's RPCs until the previous is able to be queued. By not starting goroutines, the resource usage of SendBatch is more predictable. And not starting goroutines is likely to be less expensive overall.
ciacono
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of starting goroutines we can queue each region server's collection of RPCs and only after queueing them all wait for all responses. We get a similar amount of parallelism, the only potential slow down is that we can't queue one region server's RPCs until the previous is able to be queued.
By not starting goroutines, the resource usage of SendBatch is more predictable. And not starting goroutines is likely to be less expensive overall.
This change also adds a new metric for number of splits that occur in SendBatch.