region: Use a buffered reader #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrap connection in a bufio.Reader for reading RPC responses from RegionServer. This should reduce the number of read system calls by attempting to fill a 4KB buffer on each read. Some mock tests that expected certain sizes of buffers passed to Read() had to be made more lenient.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #229 +/- ##
==========================================
- Coverage 70.29% 70.22% -0.07%
==========================================
Files 27 27
Lines 3720 3718 -2
==========================================
- Hits 2615 2611 -4
- Misses 988 991 +3
+ Partials 117 116 -1
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrap connection in a bufio.Reader for reading RPC responses from RegionServer. This should reduce the number of read system calls by attempting to fill a 4KB buffer on each read.
Some mock tests that expected certain sizes of buffers passed to Read() had to be made more lenient.